Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 39172: Linux: don't call gtk_init in the renderer process. (Closed)

Created:
11 years, 9 months ago by agl
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux: don't call gtk_init in the renderer process. Previously, our command line objects were created /after/ gtk_init had processed |argc| and |argv|. With this patch, it's created before hand and main's |argc| and |argv| are now kept pristine. Thus our command line will now reflect GTK arguments that previously it wouldn't have seen. This should be harmless.

Patch Set 1 #

Total comments: 1

Patch Set 2 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M chrome/app/chrome_dll_main.cc View 1 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
agl
11 years, 9 months ago (2009-03-05 01:08:15 UTC) #1
Evan Martin
LG
11 years, 9 months ago (2009-03-05 01:13:43 UTC) #2
Evan Martin
http://codereview.chromium.org/39172/diff/1/2 File chrome/app/chrome_dll_main.cc (right): http://codereview.chromium.org/39172/diff/1/2#newcode376 Line 376: // track of the original pointers so that ...
11 years, 9 months ago (2009-03-05 01:17:14 UTC) #3
Evan Martin
11 years, 9 months ago (2009-03-05 01:19:00 UTC) #4
LG

Powered by Google App Engine
This is Rietveld 408576698