Issue 39168: Fix a toolbar width TODO.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 39168: Fix a toolbar width TODO. (Closed)

Created:
11 years, 9 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix a toolbar width TODO.

Patch Set 1 #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	chrome/browser/gtk/browser_toolbar_view_gtk.cc	View		1 chunk	+1 line, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

11 years, 9 months ago (2009-03-05 01:11:13 UTC) #2

LG

http://codereview.chromium.org/39168/diff/1/2
File chrome/browser/gtk/browser_toolbar_view_gtk.cc (right):

http://codereview.chromium.org/39168/diff/1/2#newcode57
Line 57: gtk_widget_set_size_request(toolbar_, -1, kToolbarHeight);
Nit: Maybe add a comment explaining -1?

Expand Messages | Collapse Messages