cros_make_image_bootable, mount_gpt_image, common.sh: root filesystem changes: ext2, ro by default

build_image

 #!/bin/bash
 
 # Copyright (c) 2009 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Script to build a bootable keyfob-based chromeos system image from within
 # a chromiumos setup. This assumes that all needed packages have been built into
 # the given target's root with binary packages turned on. This script will
 # build the Chrome OS image using only pre-built binary packages.
@@ skipping 458 matching lines @@
   trap - EXIT
   ${SCRIPTS_DIR}/mount_gpt_image.sh -u -r "${ROOT_FS_DIR}" \
     -s "${STATEFUL_FS_DIR}" -e "${ESP_FS_DIR}"
 }
 
 create_base_image() {
   local image_name=$1
 
   trap "cleanup && delete_prompt" EXIT
 
-  UUID=$(uuidgen)
-
   # Create and format the root file system.
 
   # Check for loop device before creating image.
   LOOP_DEV=$(sudo losetup -f)
   if [ -z "${LOOP_DEV}" ] ; then
     echo "No free loop device.  Free up a loop device or reboot.  exiting. "
     exit 1
   fi
 
   # Create root file system disk image.
   ROOT_SIZE_BYTES=$((1024 * 1024 * ${FLAGS_rootfs_size}))
 
   # Pad out for the hash tree.
   ROOT_HASH_PAD=$((FLAGS_rootfs_hash_pad * 1024 * 1024))
   info "Padding the rootfs image by ${ROOT_HASH_PAD} bytes for hash data"
 
   dd if=/dev/zero of="${ROOT_FS_IMG}" bs=1 count=1 \
      seek=$((ROOT_SIZE_BYTES + ROOT_HASH_PAD - 1))
   sudo losetup "${LOOP_DEV}" "${ROOT_FS_IMG}"
   # Specify a block size and block count to avoid using the hash pad.
-  sudo mkfs.ext3 -b 4096 "${LOOP_DEV}" "$((ROOT_SIZE_BYTES / 4096))"
+  sudo mkfs.ext2 -b 4096 "${LOOP_DEV}" "$((ROOT_SIZE_BYTES / 4096))"
 
   # Tune and mount rootfs.
-  # TODO(wad) rename the disk label to match the GPT since we
-  #           can't change it later.
-  DISK_LABEL="C-KEYFOB"
-  sudo tune2fs -L "${DISK_LABEL}" -U "${UUID}" -c 0 -i 0 "${LOOP_DEV}"
+  DISK_LABEL="C-ROOT"
+  # Disable checking and minimize metadata differences across builds
+  # and wasted reserved space.
+  sudo tune2fs -L "${DISK_LABEL}" \
+               -U clear \
+               -T 20091119110000 \
+               -c 0 \
+               -i 0 \
+               -m 0 \

[gauravsh, 2010/10/20 19:06:55]

do you expect any performance effected from changing the reserved block
percentage from the default of 5% to 0%?

[Will Drewry, 2010/10/20 19:11:49]

I actually just wanted to make sure we use our filesystem to the fullest and not
keep extra blocks laying around for no reason on a ro filesystem.  That said, I
don't think it will have much impact except when we are very close to filling
the fs.  Thieu Le is also working on making the filesystem layout more
consistent across builds -- that will be more beneficial :)

From the man page:
"""
       -m reserved-blocks-percentage
              Set the percentage of the filesystem which may  only  be 
allocated  by  privileged  processes.
              Reserving  some  number  of  filesystem blocks for use by
privileged processes is done to avoid
              filesystem fragmentation, and to allow system daemons, such as
syslogd(8), to continue to func-
              tion  correctly  after  non-privileged  processes are prevented
from writing to the filesystem.
              Normally, the default percentage of reserved blocks is 5%.

"""

+               -r 0 \
+               -e remount-ro \
+                "${LOOP_DEV}"
+  # TODO(wad) call tune2fs prior to finalization to set the mount count to 0.
   sudo mount "${LOOP_DEV}" "${ROOT_FS_DIR}"
 
   # Create stateful partition of the same size as the rootfs.
   STATEFUL_LOOP_DEV=$(sudo losetup -f)
   if [ -z "${STATEFUL_LOOP_DEV}" ] ; then
     echo "No free loop device.  Free up a loop device or reboot.  exiting. "
     exit 1
   fi
   STATEFUL_SIZE_BYTES=$((1024 * 1024 * ${FLAGS_statefulfs_size}))
   dd if=/dev/zero of="${STATEFUL_FS_IMG}" bs=1 count=1 \
@@ skipping 235 matching lines @@
   echo "Developer image created as ${DEVELOPER_IMAGE_NAME}"
 fi
 
 print_time_elapsed
 
 echo "To copy to USB keyfob, do something like:"
 echo "  ./image_to_usb.sh --from=${OUTSIDE_OUTPUT_DIR} --to=/dev/sdX"
 echo "To convert to VMWare image, INSIDE the chroot, do something like:"
 echo "  ./image_to_vm.sh --from=${OUTSIDE_OUTPUT_DIR} --board=${BOARD}"
 echo "from the scripts directory where you entered the chroot."