Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: chrome/browser/browser.cc

Issue 39158: Take two at hooking up title bar on linux. (Closed)
Patch Set: rebase Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/gtk/browser_window_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser.cc
diff --git a/chrome/browser/browser.cc b/chrome/browser/browser.cc
index d78f6757d697116b43f6dfaca7e9181efb8153d4..8d30d28ae6f4e4e1f6aac5b9b7804ab63a7ead12 100644
--- a/chrome/browser/browser.cc
+++ b/chrome/browser/browser.cc
@@ -38,6 +38,9 @@
#ifdef CHROME_PERSONALIZATION
#include "chrome/personalization/personalization.h"
#endif
+#include "grit/chromium_strings.h"
+#include "grit/generated_resources.h"
+#include "grit/locale_settings.h"
#include "net/base/cookie_monster.h"
#include "net/base/cookie_policy.h"
#include "net/base/net_util.h"
@@ -69,9 +72,6 @@
#include "chrome/browser/window_sizer.h"
#include "chrome/common/child_process_host.h"
#include "chrome/common/win_util.h"
-#include "grit/chromium_strings.h"
-#include "grit/generated_resources.h"
-#include "grit/locale_settings.h"
#endif // OS_WIN
@@ -391,7 +391,6 @@ SkBitmap Browser::GetCurrentPageIcon() const {
}
std::wstring Browser::GetCurrentPageTitle() const {
-#if defined(OS_WIN)
TabContents* contents = tabstrip_model_.GetSelectedTabContents();
std::wstring title;
@@ -405,10 +404,6 @@ std::wstring Browser::GetCurrentPageTitle() const {
title = l10n_util::GetString(IDS_TAB_UNTITLED_TITLE);
return l10n_util::GetStringF(IDS_BROWSER_WINDOW_TITLE_FORMAT, title);
-#elif defined(OS_POSIX)
- // TODO(port): turn on when generating chrome_strings.h from grit
- return L"untitled";
-#endif
}
// static
@@ -762,6 +757,21 @@ void Browser::ViewSource() {
}
}
+bool Browser::SupportsWindowFeature(WindowFeature feature) const {
+ unsigned int features = FEATURE_INFOBAR | FEATURE_DOWNLOADSHELF;
+ if (type() == TYPE_NORMAL)
+ features |= FEATURE_BOOKMARKBAR;
+ if (!window_ || !window_->IsFullscreen()) {
+ if (type() == TYPE_NORMAL)
+ features |= FEATURE_TABSTRIP | FEATURE_TOOLBAR;
+ else
+ features |= FEATURE_TITLEBAR;
+ if ((type() & Browser::TYPE_APP) == 0)
+ features |= FEATURE_LOCATIONBAR;
+ }
+ return !!(features & feature);
+}
+
#if defined(OS_WIN)
void Browser::ClosePopups() {
@@ -977,21 +987,6 @@ void Browser::ShowDownloadsTab() {
ShowSingleDOMUITab(DownloadsUI::GetBaseURL());
}
-bool Browser::SupportsWindowFeature(WindowFeature feature) const {
- unsigned int features = FEATURE_INFOBAR | FEATURE_DOWNLOADSHELF;
- if (type() == TYPE_NORMAL)
- features |= FEATURE_BOOKMARKBAR;
- if (!window_ || !window_->IsFullscreen()) {
- if (type() == TYPE_NORMAL)
- features |= FEATURE_TABSTRIP | FEATURE_TOOLBAR;
- else
- features |= FEATURE_TITLEBAR;
- if ((type() & Browser::TYPE_APP) == 0)
- features |= FEATURE_LOCATIONBAR;
- }
- return !!(features & feature);
-}
-
void Browser::OpenClearBrowsingDataDialog() {
UserMetrics::RecordAction(L"ClearBrowsingData_ShowDlg", profile_);
window_->ShowClearBrowsingDataDialog();
« no previous file with comments | « no previous file | chrome/browser/gtk/browser_window_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698