Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2878)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/extension_view_unittest.cc

Issue 39157: Fix Purify UMR and MLK due to ExtensionViewTest:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/renderer_host/render_view_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_view_unittest.cc
===================================================================
--- chrome/browser/extensions/extension_view_unittest.cc (revision 10885)
+++ chrome/browser/extensions/extension_view_unittest.cc (working copy)
@@ -48,6 +48,10 @@
bool* did_suppress_message) {
got_message_ = true;
MessageLoopForUI::current()->Quit();
+
+ // Call super, otherwise we'll leak reply_msg.
+ ExtensionView::RunJavaScriptMessage(
+ message, default_prompt, flags, reply_msg, did_suppress_message);
}
bool got_message_;
« no previous file with comments | « no previous file | chrome/browser/renderer_host/render_view_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698