Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 3915002: Out of process Pepper (Closed)

Created:
10 years, 2 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, jam, brettw-cc_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Implement a new process type for running PPAPI plugins. The process itself is quite simple and just sets up the PPAPI dispatcher and loads the library. There is a new command line switch --ppapi-out-of-process which runs PPAPI plugins out of process using the new code path. There is some logic in RenderView and PepperPluginModule for setting up this connection, but it should be straightforward. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65614

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Total comments: 4

Patch Set 8 : '' #

Patch Set 9 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+742 lines, -30 lines) Patch
M base/scoped_native_library.h View 4 5 6 7 1 chunk +23 lines, -13 lines 0 comments Download
A base/scoped_native_library.cc View 5 1 chunk +44 lines, -0 lines 0 comments Download
M chrome/app/chrome_dll_main.cc View 1 2 3 4 5 6 7 3 chunks +5 lines, -1 line 0 comments Download
M chrome/app/dummy_main_functions.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/browser/ppapi_plugin_process_host.h View 1 2 3 4 5 6 7 8 1 chunk +57 lines, -0 lines 0 comments Download
A chrome/browser/ppapi_plugin_process_host.cc View 1 2 3 4 5 6 7 1 chunk +101 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 7 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.h View 1 2 3 4 5 6 7 4 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 2 3 4 5 6 7 3 chunks +13 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 5 6 7 2 chunks +19 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/child_process_info.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/child_process_info.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 6 7 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/common/pepper_plugin_registry.h View 1 2 3 4 5 6 7 2 chunks +15 lines, -2 lines 0 comments Download
M chrome/common/pepper_plugin_registry.cc View 1 2 3 4 5 6 7 7 chunks +25 lines, -2 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 2 3 4 5 6 7 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/common/sandbox_policy.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/ppapi_plugin/ppapi_plugin_main.cc View 2 3 4 5 1 chunk +34 lines, -0 lines 0 comments Download
A chrome/ppapi_plugin/ppapi_process.h View 2 3 4 5 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/ppapi_plugin/ppapi_process.cc View 2 3 4 5 1 chunk +11 lines, -0 lines 0 comments Download
A chrome/ppapi_plugin/ppapi_thread.h View 2 3 4 5 1 chunk +67 lines, -0 lines 0 comments Download
A chrome/ppapi_plugin/ppapi_thread.cc View 2 3 4 5 1 chunk +136 lines, -0 lines 0 comments Download
M chrome/renderer/pepper_plugin_delegate_impl.h View 1 2 3 4 5 6 7 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/renderer/pepper_plugin_delegate_impl.cc View 1 2 3 4 5 6 7 4 chunks +19 lines, -2 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 2 3 4 5 6 7 1 chunk +9 lines, -2 lines 0 comments Download
M ipc/ipc_message_utils.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_graphics_2d.cc View 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
M webkit/glue/plugins/pepper_plugin_module.h View 1 2 3 4 5 6 7 4 chunks +27 lines, -1 line 0 comments Download
M webkit/glue/plugins/pepper_plugin_module.cc View 1 2 3 4 5 6 7 8 chunks +62 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
10 years, 1 month ago (2010-11-03 19:57:34 UTC) #1
jam
don't you also need to update sandbox_policy.cc' StartProcessWithAccess() so that the process is sandboxed? http://codereview.chromium.org/3915002/diff/106001/107005 ...
10 years, 1 month ago (2010-11-04 21:57:25 UTC) #2
brettw
New snap up with comments addressed.
10 years, 1 month ago (2010-11-07 22:04:55 UTC) #3
jam
10 years, 1 month ago (2010-11-08 06:30:53 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698