In List::Add, correctly handle the case of adding a reference to a...

src/list-inl.h

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 16 matching lines @@
 
 #ifndef V8_LIST_INL_H_
 #define V8_LIST_INL_H_
 
 #include "list.h"
 
 namespace v8 { namespace internal {
 
 
 template<typename T, class P>
-T& List<T, P>::Add(const T& element) {
-  if (length_ >= capacity_) {
+void List<T, P>::Add(const T& element) {
+  if (length_ < capacity_) {
+    data_[length_++] = element;
+  } else {
     // Grow the list capacity by 50%, but make sure to let it grow
     // even when the capacity is zero (possible initial case).
     int new_capacity = 1 + capacity_ + (capacity_ >> 1);
     T* new_data = NewData(new_capacity);
     memcpy(new_data, data_, capacity_ * sizeof(T));
+    // Since the element reference could be an element of the list,

[Kasper Lund, 2009/03/05 06:21:03]

It would be nice with a test of this functionality.

+    // assign it to the new backing store before deleting the old.
+    new_data[length_++] = element;
     DeleteData(data_);
     data_ = new_data;
     capacity_ = new_capacity;
   }
-  return data_[length_++] = element;
 }
 
 
 template<typename T, class P>
-Vector<T> List<T, P>::AddBlock(const T& element, int count) {
+Vector<T> List<T, P>::AddBlock(T value, int count) {
   int start = length_;
-  for (int i = 0; i < count; i++)
-    Add(element);
+  for (int i = 0; i < count; i++) Add(value);
   return Vector<T>(&data_[start], count);
 }
 
 
 template<typename T, class P>
-T& List<T, P>::Insert(int i, const T& element) {
-  int free_index = length_ - 1;
-  Add(last());  // Add grows the list if necessary.
-  while (free_index > i) {
-    data_[free_index] = data_[free_index - 1];
-    free_index--;
-  }
-  data_[free_index] = element;
-}
-
-
-template<typename T, class P>
 T List<T, P>::Remove(int i) {
   T element = at(i);
   length_--;
   while (i < length_) {
     data_[i] = data_[i + 1];
     i++;
   }
   return element;
 }
 
@@ skipping 48 matching lines @@
   ASSERT(capacity >= 0);
   data_ = (capacity > 0) ? NewData(capacity) : NULL;
   capacity_ = capacity;
   length_ = 0;
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_LIST_INL_H_