In List::Add, correctly handle the case of adding a reference to a...

In List::Add, correctly handle the case of adding a reference to a
preexisting list element to a list, and to not return anything (we
never used the return value).  Remove List::Insert, it is not
currently used or needed.  Change List::AddBlock to take a copy of
the element to be replicated rather than a reference.


Committed: http://code.google.com/p/v8/source/detail?r=1424

[Kasper Lund, 2009-03-05 06:21:03]

LGTM.

http://codereview.chromium.org/39148/diff/1/3
File src/list-inl.h (right):

http://codereview.chromium.org/39148/diff/1/3#newcode46
Line 46: // Since the element reference could be an element of the list,
It would be nice with a test of this functionality.