Issue 39126: Fixed issue 253. No longer assuming that the target of a property lookup is a...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 39126: Fixed issue 253. No longer assuming that the target of a property lookup is a... (Closed)

Created:
11 years, 9 months ago by olehougaard

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fixed issue 253. No longer assuming that the target of a property lookup is a JSObject. Committed: http://code.google.com/p/v8/source/detail?r=1416

Patch Set 1 #

Total comments: 2

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -4 lines)			Patch
	M	src/runtime.cc	View		1 chunk	+10 lines, -4 lines	0 comments	Download
	A	test/mjsunit/regress/regress-253.js	View		1 chunk	+31 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/39126/diff/1/2 File test/mjsunit/regress/regress-253.js (right): http://codereview.chromium.org/39126/diff/1/2#newcode31 Line 31: assertEquals(2, x[0] = 2); This test case ...

11 years, 9 months ago (2009-03-04 11:45:29 UTC) #2

olehougaard

11 years, 9 months ago (2009-03-04 11:56:57 UTC) #3

http://codereview.chromium.org/39126/diff/1/2
File test/mjsunit/regress/regress-253.js (right):

http://codereview.chromium.org/39126/diff/1/2#newcode31
Line 31: assertEquals(2, x[0] = 2);
On 2009/03/04 11:45:30, Mads Ager wrote:
> This test case does not hit your optimization pattern, so it is not really a
> regression test.  Just remove the return value assertions?

Done

Expand Messages | Collapse Messages