Issue 391075: Revert 32057, 32058, 32059, 32062 because they still have unwanted side-effects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 391075: Revert 32057, 32058, 32059, 32062 because they still have unwanted side-effects. (Closed)

Created:
11 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Revert 32057, 32058, 32059, 32062 because they still have unwanted side-effects. Revert "Group SCM-specific functions in classes to simplify generalization of the interface." Revert "Fix 2 recently introduced errors." Revert "Fix a variable aliasing error." Revert "Fix typo." TBR=dpranke TEST=none BUG=none

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+679 lines, -699 lines)			Patch
M	gcl.py	View	12 chunks	+44 lines, -14 lines	0 comments	Download
M	gclient.py	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	gclient_scm.py	View	19 chunks	+62 lines, -47 lines	0 comments	Download
M	gclient_utils.py	View	7 chunks	+11 lines, -11 lines	0 comments	Download
M	git_cl_hooks.py	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	presubmit_support.py	View	13 chunks	+17 lines, -17 lines	0 comments	Download
M	revert.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	scm.py	View	1 chunk	+322 lines, -402 lines	0 comments	Download
M	tests/gcl_unittest.py	View	4 chunks	+27 lines, -20 lines	0 comments	Download
M	tests/gclient_scm_test.py	View	11 chunks	+33 lines, -43 lines	0 comments	Download
M	tests/gclient_test.py	View	2 chunks	+12 lines, -5 lines	0 comments	Download
M	tests/presubmit_unittest.py	View	21 chunks	+59 lines, -65 lines	0 comments	Download
M	tests/revert_unittest.py	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	tests/scm_unittest.py	View	11 chunks	+33 lines, -57 lines	0 comments	Download
M	tests/super_mox.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/trychange_unittest.py	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	trychange.py	View	3 chunks	+46 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm after a quick skimming-over

Expand Messages | Collapse Messages