Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issue 391051: Allow a platform to indicate that some CPU features are always... (Closed)

Created:
11 years, 1 month ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Allow a platform to indicate that some CPU features are always available. We use this to ensure that snapshots on MacOSX can use SSE2 instructions. Also clean up and assertify the handling of things we can't do when we are generating a snapshot. Fix a bug in the new serialization tests where they activated Snapshot::enable() too late after code had been generated that assumed no snapshots. Committed: http://code.google.com/p/v8/source/detail?r=3301

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -134 lines) Patch
M src/arm/assembler-arm.h View 3 chunks +10 lines, -6 lines 1 comment Download
M src/arm/assembler-arm.cc View 16 chunks +38 lines, -26 lines 0 comments Download
M src/arm/codegen-arm.cc View 9 chunks +17 lines, -17 lines 0 comments Download
M src/globals.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.h View 3 chunks +10 lines, -9 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 20 chunks +34 lines, -21 lines 0 comments Download
M src/ia32/codegen-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/codegen-ia32.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform.h View 1 chunk +8 lines, -1 line 0 comments Download
M src/platform-freebsd.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/platform-linux.cc View 1 3 chunks +15 lines, -2 lines 0 comments Download
M src/platform-macos.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/platform-nullos.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/platform-win32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/serialize.h View 2 chunks +12 lines, -1 line 0 comments Download
M src/serialize.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/assembler-x64.h View 3 chunks +11 lines, -16 lines 0 comments Download
M src/x64/assembler-x64.cc View 4 chunks +12 lines, -3 lines 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
11 years, 1 month ago (2009-11-13 12:12:42 UTC) #1
Mads Ager (chromium)
11 years, 1 month ago (2009-11-13 12:28:35 UTC) #2
STV!

http://codereview.chromium.org/391051/diff/3001/4019
File src/arm/assembler-arm.h (right):

http://codereview.chromium.org/391051/diff/3001/4019#newcode452
Line 452: ASSERT(!Serializer::enabled() || (found_by_runtime_probing_ & (1u <<
f)) == 0);
With lines this long I wonder if it lints? ;-)

Powered by Google App Engine
This is Rietveld 408576698