Windowless plugins: basic drawing works.

Windowless plugins: basic drawing works.

Slow as hell, got some bugs, but it's a start.

[darin (slow to review), 2009-03-04 07:00:34]

drive-by nits:

http://codereview.chromium.org/39105/diff/1011/1021
File webkit/glue/webplugin_impl.cc (right):

http://codereview.chromium.org/39105/diff/1011/1021#newcode714
Line 714: #else
#elif defined(OS_LINUX)

can you also fix the bad whitespace in the OS_MACOSX case?

http://codereview.chromium.org/39105/diff/1011/1021#newcode723
Line 723: delegate_->Paint((void*)context,
webkit_glue::FromIntRect(window_rect));
reinterpret_cast

[darin (slow to review), 2009-03-04 07:02:12]

> reinterpret_cast

actually, i don't know if reinterpret_cast is right... just meant that this
should be a C++ style cast.

[Evan Martin, 2009-03-04 07:07:15]

On 2009/03/04 07:02:12, darin wrote:
> > reinterpret_cast
> 
> actually, i don't know if reinterpret_cast is right... just meant that this
> should be a C++ style cast.

I really should just fix the prototype for the function (the typedef that the
above versions use exists only for this one call), but I haven't yet figured out
what I really want to be sending through in this call.  Right now it's an Xlib
type but bringing in Xlib headers is doom to the codebase.

[Dean McNamee, 2009-03-04 16:05:07]

Hey Evan,

I guess I was just sort of unsure if this is the best approach for allocating
the backing pixmap.  It seems to me it would be simplest to just have our own
allocated pixmap on the plugin instance and reuse it.  Then we have to blit to
whatever webkit gives us, but I'm not sure that's a huge deal worth optimizing
yet?  All of the skia changes kinda spread the code all over, and I'm not sure
it would be reused for anything else?

[darin (slow to review), 2009-03-04 16:37:01]

one more nit...

http://codereview.chromium.org/39105/diff/1011/1019
File webkit/glue/plugins/plugin_instance.h (right):

http://codereview.chromium.org/39105/diff/1011/1019#newcode19
Line 19: #include "build/build_config.h"
nit: there's no need to include build_config.h here.  it is already included by
basictypes.h.

[darin (slow to review), 2009-03-04 16:42:09]

one more nit...

[jam, 2009-03-04 20:19:56]

webkit changes lgtm