Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: tests/gclient_utils_test.py

Issue 391048: gclient: fix another bug where ssh urls weren't parsed correctly (Closed)
Patch Set: fix per code review Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gclient_utils.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/gclient_utils_test.py
diff --git a/tests/gclient_utils_test.py b/tests/gclient_utils_test.py
index 339de38d20dd8fd3b3bc4bfc8ae9bd1c4b1fdf40..6c9a107d95d146a4c63cbc417b65496afc7f2f27 100644
--- a/tests/gclient_utils_test.py
+++ b/tests/gclient_utils_test.py
@@ -46,6 +46,35 @@ class SubprocessCallAndFilterTestCase(SuperMoxTestBase):
self.assertEquals(capture_list, ['cc', 'dd'])
+class SplitUrlRevisionTestCase(SuperMoxTestBase):
+ def testSSHUrl(self):
+ url = "ssh://test@example.com/test.git"
+ rev = "ac345e52dc"
+ out_url, out_rev = gclient_utils.SplitUrlRevision(url)
+ self.assertEquals(out_rev, None)
+ self.assertEquals(out_url, url)
+ out_url, out_rev = gclient_utils.SplitUrlRevision("%s@%s" % (url, rev))
+ self.assertEquals(out_rev, rev)
+ self.assertEquals(out_url, url)
+ url = "ssh://example.com/test.git"
+ out_url, out_rev = gclient_utils.SplitUrlRevision(url)
+ self.assertEquals(out_rev, None)
+ self.assertEquals(out_url, url)
+ out_url, out_rev = gclient_utils.SplitUrlRevision("%s@%s" % (url, rev))
+ self.assertEquals(out_rev, rev)
+ self.assertEquals(out_url, url)
+
+ def testSVNUrl(self):
+ url = "svn://example.com/test"
+ rev = "ac345e52dc"
+ out_url, out_rev = gclient_utils.SplitUrlRevision(url)
+ self.assertEquals(out_rev, None)
+ self.assertEquals(out_url, url)
+ out_url, out_rev = gclient_utils.SplitUrlRevision("%s@%s" % (url, rev))
+ self.assertEquals(out_rev, rev)
+ self.assertEquals(out_url, url)
+
+
if __name__ == '__main__':
import unittest
unittest.main()
« no previous file with comments | « gclient_utils.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698