Test program for OpenMAX video decoding

Test program for OpenMAX video decoding
Including gyp file for openmax and the test application.
The test application will link against libOmxCore.so which is provided
by the target system.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31957

[Alpha Left Google, 2009-11-12 07:28:16]

This will provide a buildable test application for OpenMAX video decoding if the
target system provides libOmxCore.so.

Building this will require my other CL of ffmpeg for arm which fixes some build
issues on arm.

[awong, 2009-11-13 19:34:43]

http://codereview.chromium.org/391030/diff/1/3
File media/omx/omx_test.cc (right):

http://codereview.chromium.org/391030/diff/1/3#newcode1
Line 1: #include "base/at_exit.h"
You need a licnense blob.

http://codereview.chromium.org/391030/diff/1/3#newcode6
Line 6: #include "media/omx/omx_video_decoder.h"
If we're planning on having other people use this, comment it to death please.
Especially comment waht message_loop_.Quit() does, why it's safe, what the
threading semantics are, etc., etc.

[Alpha Left Google, 2009-11-13 19:56:22]

Added a lot of comments. Please take another look.

[awong, 2009-11-13 20:04:58]

http://codereview.chromium.org/391030/diff/3001/4002
File media/omx/omx_test.cc (right):

http://codereview.chromium.org/391030/diff/3001/4002#newcode34
Line 34: decoder_->Setup(component, codec);
Technically no work is supposed to be done in the constructor. This *should* be
in an init method. Would that be hard tod o?

http://codereview.chromium.org/391030/diff/3001/4002#newcode40
Line 40: // feed more buffer into the decoder.
buffer -> buffers

http://codereview.chromium.org/391030/diff/3001/4002#newcode58
Line 58: // In this case delete the previous buffer and enqueue a new one.
this case delete -> this case, delete

http://codereview.chromium.org/391030/diff/3001/4002#newcode60
Line 60: // the last buffer is an end-of-stream buffer, when we have stopped and
stopped and -> stopped, and

You need to review your comma rules. :)

http://codereview.chromium.org/391030/diff/3001/4002#newcode69
Line 69: // This callback is received when the decoder has completed an decoding
an decoding -> a decoding

http://codereview.chromium.org/391030/diff/3001/4002#newcode85
Line 85: // This method feed the decoder with 32KB of input data.
feed -> feeds

http://codereview.chromium.org/391030/diff/3001/4005
File third_party/openmax/openmax.gyp (right):

http://codereview.chromium.org/391030/diff/3001/4005#newcode8
Line 8: 'target_name': 'il',
This needs a comment, or a better target name.  Just calling this "il" is really
not very descriptive.

[Alpha Left Google, 2009-11-13 21:59:41]

Fixed the comments and make it work on build slaves.

[awong, 2009-11-13 22:03:09]

LGTM

1 more nit

http://codereview.chromium.org/391030/diff/5016/2020
File media/omx/omx_test.cc (right):

http://codereview.chromium.org/391030/diff/5016/2020#newcode67
Line 67: // task and give us some output data. The buffer is owned by the
decoder.
give us -> given us