src/runtime.cc - Issue 391014: Small optimizations to parseInt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 391014: Small optimizations to parseInt (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

===================================================================

--- src/runtime.cc (revision 3247)

+++ src/runtime.cc (working copy)

@@ -3387,8 +3387,7 @@

NoHandleAllocation ha;

CONVERT_CHECKED(String, s, args[0]);

- CONVERT_DOUBLE_CHECKED(n, args[1]);

- int radix = FastD2I(n);

+ CONVERT_SMI_CHECKED(radix, args[1]);

Erik Corry 2009/11/11 11:16:49 This version doesn't work if the argument is not a

Lasse Reichstein 2009/11/11 11:43:34 It's perfectly fine to throw an exception for a no

Erik Corry 2009/11/13 12:24:23 My apologies, I was too fast with this comment. T

s->TryFlattenIfNotFlat();

« no previous file with comments | « no previous file | src/v8natives.js » ('j') | src/v8natives.js » ('J')