Don't do work in the SharedIOBuffer constructor; use an Init method instead. ...

chrome/browser/renderer_host/async_resource_handler.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/async_resource_handler.h"
 
 #include "base/logging.h"
 #include "base/process.h"
 #include "base/shared_memory.h"
 #include "chrome/common/render_messages.h"
@@ skipping 13 matching lines @@
 const int kMaxReadBufSize = 524288;
 
 }  // namespace
 
 // Our version of IOBuffer that uses shared memory.
 class SharedIOBuffer : public net::IOBuffer {
  public:
   explicit SharedIOBuffer(int buffer_size)
       : net::IOBuffer(),
         ok_(false),
-        buffer_size_(buffer_size) {
-    if (shared_memory_.Create(std::wstring(), false, false, buffer_size) &&
-        shared_memory_.Map(buffer_size)) {
+        buffer_size_(buffer_size) {}
+
+  bool Init() {
+    if (shared_memory_.Create(std::wstring(), false, false, buffer_size_) &&
+        shared_memory_.Map(buffer_size_)) {
+      data_ = reinterpret_cast<char*>(shared_memory_.memory());
+      // TODO(hawk): Remove after debugging bug 16371.
+      CHECK(data_);
       ok_ = true;
-      data_ = reinterpret_cast<char*>(shared_memory_.memory());
     }
+    return ok_;
   }
 
   base::SharedMemory* shared_memory() { return &shared_memory_; }
   bool ok() { return ok_; }
   int buffer_size() { return buffer_size_; }
 
  private:
   ~SharedIOBuffer() {
     // TODO(willchan): Remove after debugging bug 16371.
     CHECK(g_spare_read_buffer != this);
@@ skipping 54 matching lines @@
   if (g_spare_read_buffer) {
     DCHECK(!read_buffer_);
     read_buffer_.swap(&g_spare_read_buffer);
     // TODO(willchan): Remove after debugging bug 16371.
     CHECK(read_buffer_->data());
 
     *buf = read_buffer_.get();
     *buf_size = read_buffer_->buffer_size();
   } else {
     read_buffer_ = new SharedIOBuffer(next_buffer_size_);
-    if (!read_buffer_->ok()) {
+    if (!read_buffer_->Init()) {
       DLOG(ERROR) << "Couldn't allocate shared io buffer";
+      read_buffer_ = NULL;
       return false;
     }
     // TODO(willchan): Remove after debugging bug 16371.
     CHECK(read_buffer_->data());
     *buf = read_buffer_.get();
     *buf_size = next_buffer_size_;
   }
 
   return true;
 }
@@ skipping 57 matching lines @@
 
 // static
 void AsyncResourceHandler::GlobalCleanup() {
   if (g_spare_read_buffer) {
     // Avoid the CHECK in SharedIOBuffer::~SharedIOBuffer().
     SharedIOBuffer* tmp = g_spare_read_buffer;
     g_spare_read_buffer = NULL;
     tmp->Release();
   }
 }