Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 3909001: Added a function to update chroot sudoers automatically. (Closed)

Created:
10 years, 2 months ago by dianders
Modified:
6 years, 3 months ago
Reviewers:
davidjames, piman
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Added a function to update chroot sudoers automatically. This function is now called by enter_chroot.sh. A separate change will call the function from make_chroot Change-Id: I4fc07c413e56db3e5e7617428f20f2ffc02790d7 BUG=chromium-os:7072 TEST=Took root out of sudoers and ran enter_chroot.sh script; saw that it was re-added. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=0c9e88d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M common.sh View 1 chunk +20 lines, -0 lines 1 comment Download
M enter_chroot.sh View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dianders
This is the first half of the change to auto-update the chroot so that people ...
10 years, 2 months ago (2010-10-19 20:49:41 UTC) #1
piman
David may have other ideas about how to make it so that people don't even ...
10 years, 2 months ago (2010-10-19 20:59:31 UTC) #2
dianders
Antoine, It turns out that you don't need to exit the chroot. If you were ...
10 years, 2 months ago (2010-10-19 21:09:49 UTC) #3
davidjames
LGTM. Note that we'll need the make_chroot change as well before we can commit your ...
10 years, 2 months ago (2010-10-19 21:24:23 UTC) #4
davidjames
10 years, 2 months ago (2010-10-19 21:24:35 UTC) #5

          

Powered by Google App Engine
This is Rietveld 408576698