Issue 39086: Fix a crash in chrome.exe caused by the external tab container instance getti...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 39086: Fix a crash in chrome.exe caused by the external tab container instance getti... (Closed)

Created:
11 years, 9 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
amit

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a crash in chrome.exe caused by the external tab container instance getting destroyed without going through the proper window shutdown sequence when the external host crashes. The fix is to ensure that we clean up correctly when the external tab instance goes away. Will add a unit test in a subsequent CB. Bug=1688967 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10962

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -7 lines)			Patch
	M	chrome/browser/external_tab_container.h	View	1 2	2 chunks	+5 lines, -1 line	0 comments	Download
	M	chrome/browser/external_tab_container.cc	View	1 2	3 chunks	+13 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages