Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1435)

Unified Diff: src/stub-cache.h

Issue 39014: Add a meaningful name when disassembling code. This makes it easier... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/stub-cache.h
===================================================================
--- src/stub-cache.h (revision 1406)
+++ src/stub-cache.h (working copy)
@@ -362,7 +362,8 @@
static void GenerateLoadMiss(MacroAssembler* masm, Code::Kind kind);
protected:
- Object* GetCodeWithFlags(Code::Flags flags);
+ Object* GetCodeWithFlags(Code::Flags flags, char* name);
+ Object* GetCodeWithFlags(Code::Flags flags, String* name);
MacroAssembler* masm() { return &masm_; }
@@ -374,19 +375,24 @@
class LoadStubCompiler: public StubCompiler {
public:
- Object* CompileLoadField(JSObject* object, JSObject* holder, int index);
+ Object* CompileLoadField(JSObject* object,
+ JSObject* holder,
+ int index,
+ String* name);
Object* CompileLoadCallback(JSObject* object,
JSObject* holder,
- AccessorInfo* callback);
+ AccessorInfo* callback,
+ String* name);
Object* CompileLoadConstant(JSObject* object,
JSObject* holder,
- Object* value);
+ Object* value,
+ String* name);
Object* CompileLoadInterceptor(JSObject* object,
JSObject* holder,
String* name);
private:
- Object* GetCode(PropertyType);
+ Object* GetCode(PropertyType type, String* name);
};
@@ -412,7 +418,7 @@
Object* CompileLoadFunctionPrototype(String* name);
private:
- Object* GetCode(PropertyType);
+ Object* GetCode(PropertyType type, String* name);
};
@@ -428,7 +434,7 @@
Object* CompileStoreInterceptor(JSObject* object, String* name);
private:
- Object* GetCode(PropertyType type);
+ Object* GetCode(PropertyType type, String* name);
};
@@ -440,7 +446,7 @@
String* name);
private:
- Object* GetCode(PropertyType type);
+ Object* GetCode(PropertyType type, String* name);
};
@@ -448,7 +454,10 @@
public:
explicit CallStubCompiler(int argc) : arguments_(argc) { }
- Object* CompileCallField(Object* object, JSObject* holder, int index);
+ Object* CompileCallField(Object* object,
+ JSObject* holder,
+ int index,
+ String* name);
Object* CompileCallConstant(Object* object,
JSObject* holder,
JSFunction* function,
@@ -462,7 +471,7 @@
const ParameterCount& arguments() { return arguments_; }
- Object* GetCode(PropertyType type);
+ Object* GetCode(PropertyType type, String* name);
};

Powered by Google App Engine
This is Rietveld 408576698