Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 39011: Clean up a few comments / formatting related to the location bar. (Closed)

Created:
11 years, 9 months ago by Dean McNamee
Modified:
9 years, 7 months ago
Reviewers:
Peter Kasting, sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Clean up a few comments / formatting related to the location bar. Correct the includes, forward declare TabContents.

Patch Set 1 #

Patch Set 2 : Typo #

Patch Set 3 : #include <string> #

Patch Set 4 : Forward delcare TabContents. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M chrome/browser/location_bar.h View 1 2 3 4 chunks +15 lines, -10 lines 0 comments Download
M chrome/browser/views/location_bar_view.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Dean McNamee
I changed the comment in location_bar because I had originally read the code and not ...
11 years, 9 months ago (2009-03-03 12:59:20 UTC) #1
sky
LGTM
11 years, 9 months ago (2009-03-03 16:34:15 UTC) #2
Dean McNamee
Hey Peter, I just committed this, it's pretty straight forward and I wanted to go ...
11 years, 9 months ago (2009-03-03 16:43:31 UTC) #3
Peter Kasting
11 years, 9 months ago (2009-03-03 17:46:09 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698