Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1365)

Unified Diff: src/top.cc

Issue 39009: Dump more stack frames to perf log when executing a C++ function. (Closed)
Patch Set: Changes according to Soren's comments Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/platform.h ('k') | test/cctest/test-log-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/top.cc
diff --git a/src/top.cc b/src/top.cc
index aa0c58e9101c3cc72b8a47aedbe7070cb029bcd6..ed4cb4257d3da587a0d75dbdd2e213de82adcd25 100644
--- a/src/top.cc
+++ b/src/top.cc
@@ -668,26 +668,6 @@ Object* Top::PromoteScheduledException() {
}
-// NOTE: The stack trace frame iterator is an iterator that only
-// traverse proper JavaScript frames; that is JavaScript frames that
-// have proper JavaScript functions. This excludes the problematic
-// functions in runtime.js.
-class StackTraceFrameIterator: public JavaScriptFrameIterator {
- public:
- StackTraceFrameIterator() {
- if (!done() && !frame()->function()->IsJSFunction()) Advance();
- }
-
- void Advance() {
- while (true) {
- JavaScriptFrameIterator::Advance();
- if (done()) return;
- if (frame()->function()->IsJSFunction()) return;
- }
- }
-};
-
-
void Top::PrintCurrentStackTrace(FILE* out) {
StackTraceFrameIterator it;
while (!it.done()) {
« no previous file with comments | « src/platform.h ('k') | test/cctest/test-log-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698