Make accessors for hidden properties object not touch interceptors

Make accessors for hidden properties object not touch interceptors.

Interceptors cannot provide a meaningful result for hidden_symbol anyway and some of them crash on empty property name.


Related Chromium issue: http://code.google.com/p/chromium/issues/detail?id=27385


Committed: http://code.google.com/p/v8/source/detail?r=3294

[yurys, 2009-11-12 15:01:28]

Pease review this. Thanks Vitaly for help!

[Christian Plesner Hansen, 2009-11-12 15:30:00]

Lgtm

http://codereview.chromium.org/390020/diff/3007/3011
File src/objects-inl.h (right):

http://codereview.chromium.org/390020/diff/3007/3011#newcode2997
Line 2997: // TODO(yurys): this may be useful in other places too where
JSGlobalProxy
TODOs should be of the form TODO(<issue number>) where the issue number
corresponds to an issue describing the TODO.

http://codereview.chromium.org/390020/diff/3007/3011#newcode2999
Line 2999: Object* JSObject::GetHiddenPropertiesObjectHolder() {
As you say in the comment, this is actually a pretty general function.  How
about giving it a more descriptive name maybe, off the top of my head,
BypassGlobalProxy.

http://codereview.chromium.org/390020/diff/3007/3011#newcode3013
Line 3013: this, Heap::hidden_symbol(), false) != ABSENT;
One argument per line.

http://codereview.chromium.org/390020/diff/3007/3010
File src/objects.h (right):

http://codereview.chromium.org/390020/diff/3007/3010#newcode1437
Line 1437: // Instead they are stored on an auxiliary Object stored as a local
That should be "auxiliary JSObject" right?

[yurys, 2009-11-12 16:13:16]

http://codereview.chromium.org/390020/diff/3007/3011
File src/objects-inl.h (right):

http://codereview.chromium.org/390020/diff/3007/3011#newcode2997
Line 2997: // TODO(yurys): this may be useful in other places too where
JSGlobalProxy
On 2009/11/12 15:30:00, Christian Plesner Hansen wrote:
> TODOs should be of the form TODO(<issue number>) where the issue number
> corresponds to an issue describing the TODO.

Done.

http://codereview.chromium.org/390020/diff/3007/3011#newcode2999
Line 2999: Object* JSObject::GetHiddenPropertiesObjectHolder() {
On 2009/11/12 15:30:00, Christian Plesner Hansen wrote:
> As you say in the comment, this is actually a pretty general function.  How
> about giving it a more descriptive name maybe, off the top of my head,
> BypassGlobalProxy.

Done.

http://codereview.chromium.org/390020/diff/3007/3011#newcode3013
Line 3013: this, Heap::hidden_symbol(), false) != ABSENT;
On 2009/11/12 15:30:00, Christian Plesner Hansen wrote:
> One argument per line.

Done.

[Mads Ager (chromium), 2009-11-13 06:41:16]

LGTM, I will merge this to the 1.3 branch.