Don't expose hidden properties object as an object property in debugger

All hidden properties of an object are stored in a value of a regular property with empty name. This property may confuse user if returned among regular properties. It should not be exposed directly by ObjectMirror. Should we want an access to these properties from debugger we need to implement an explicit method for that.

Current patch filters the hidden_symbol from property names returned to ObjectMirror.

See http://crbug.com/26491


Committed: http://code.google.com/p/v8/source/detail?r=3265

[Mads Ager (chromium), 2009-11-10 16:04:08]

LGTM

http://codereview.chromium.org/390001/diff/2001/3002
File src/runtime.cc (right):

http://codereview.chromium.org/390001/diff/2001/3002#newcode6026
Line 6026: Object* e = old_names->get(i);
Rename 'e' to 'name'?

http://codereview.chromium.org/390001/diff/2001/3001
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/390001/diff/2001/3001#newcode3442
Line 3442: // See http://crbug.com/26491
Could you add a one line description before the bug link?

[yurys, 2009-11-10 16:09:07]

http://codereview.chromium.org/390001/diff/2001/3002
File src/runtime.cc (right):

http://codereview.chromium.org/390001/diff/2001/3002#newcode6026
Line 6026: Object* e = old_names->get(i);
On 2009/11/10 16:04:08, Mads Ager wrote:
> Rename 'e' to 'name'?

Done.

http://codereview.chromium.org/390001/diff/2001/3001
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/390001/diff/2001/3001#newcode3442
Line 3442: // See http://crbug.com/26491
On 2009/11/10 16:04:08, Mads Ager wrote:
> Could you add a one line description before the bug link?

Done.

[Søren Thygesen Gjesse, 2009-11-11 08:55:34]

On 2009/11/10 16:09:07, Yury Semikhatsky wrote:
> http://codereview.chromium.org/390001/diff/2001/3002
> File src/runtime.cc (right):
> 
> http://codereview.chromium.org/390001/diff/2001/3002#newcode6026
> Line 6026: Object* e = old_names->get(i);
> On 2009/11/10 16:04:08, Mads Ager wrote:
> > Rename 'e' to 'name'?
> 
> Done.
> 
> http://codereview.chromium.org/390001/diff/2001/3001
> File test/cctest/test-debug.cc (right):
> 
> http://codereview.chromium.org/390001/diff/2001/3001#newcode3442
> Line 3442: // See http://crbug.com/26491
> On 2009/11/10 16:04:08, Mads Ager wrote:
> > Could you add a one line description before the bug link?
> 
> Done.

LGTM,

As the hidden properties are used by the embedder I don't think we would ever
want to expose the content of these in the JavaScript debugger, unless we add
some 'expose internals' targeted as debugging of the bindings at the JavaScript
level.