Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 3898007: Strtod fast-case that uses DiyFps and cached powers of ten. (Closed)

Created:
10 years, 2 months ago by Florian Loitsch
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Strtod fast-case that uses DiyFps and cached powers of ten. This is a fixed version of r5677. Committed: http://code.google.com/p/v8/source/detail?r=5686

Patch Set 1 #

Patch Set 2 : Fix conversion. #

Patch Set 3 : Add 'explicit'-keyword to constructor. #

Patch Set 4 : Strtod fast-case that uses DiyFps and cached powers of ten.... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+367 lines, -44 lines) Patch
M src/cached-powers.h View 1 2 3 1 chunk +26 lines, -4 lines 0 comments Download
M src/cached-powers.cc View 1 2 3 2 chunks +41 lines, -16 lines 0 comments Download
M src/double.h View 1 2 3 4 chunks +54 lines, -7 lines 0 comments Download
M src/fast-dtoa.cc View 1 2 3 2 chunks +8 lines, -6 lines 0 comments Download
M src/strtod.cc View 1 2 3 9 chunks +190 lines, -11 lines 0 comments Download
M test/cctest/test-strtod.cc View 1 2 3 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Florian Loitsch
Patch Set 1 equals the CL that I had commited earlier (r5677). The diff (Patch ...
10 years, 2 months ago (2010-10-20 18:51:45 UTC) #1
William Hesse
10 years, 2 months ago (2010-10-21 11:28:57 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698