Issue 3898006: Prepare push to trunk. Now working on version 2.5.2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3898006: Prepare push to trunk. Now working on version 2.5.2. (Closed)

Created:
10 years, 2 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Prepare push to trunk. Now working on version 2.5.2. Committed: http://code.google.com/p/v8/source/detail?r=5672

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -1 line)			Patch
	M	ChangeLog	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
	M	src/version.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 2 months ago (2010-10-20 11:25:52 UTC) #2

LGTM

http://codereview.chromium.org/3898006/diff/1/2
File ChangeLog (right):

http://codereview.chromium.org/3898006/diff/1/2#newcode13
ChangeLog:13: (by Justin Schuh <jschuh@chromium.org>)
I would remove the attribution line here. The Solaris platform fix should be
attributed as well if we want these. Let's just leave them out. The code reviews
contains details and so does the svn history.

Expand Messages | Collapse Messages