Issue 389025: Change type of extraRecipients to a list....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 389025: Change type of extraRecipients to a list.... (Closed)

Created:
11 years, 1 month ago by chase

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com, Nicolas Sylvain, pam+watch_chromium.org

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/tools/buildbot/

Visibility:
Public.

Description

Change type of extraRecipients to a list. Buildbot's MailNotifier has a bug that only occurs when extraRecipients is a tuple and sendToInterestedUsers is true. Changing extraRecipients type to a list avoids the bug. BUG=none TEST=GateKeeper should send mail again Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31876

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	master.chromeos/master.cfg	View	1 chunk	+1 line, -1 line	0 comments	Download
M	master.chromium/master.cfg	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	master.nacl/master.cfg	View	1 chunk	+1 line, -1 line	0 comments	Download
M	master.o3d/master.cfg	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

chase

On 2009/11/12 22:20:01, chase wrote: > Testing the master.chromium change now on my buildbot. Verified ...

11 years, 1 month ago (2009-11-12 23:16:34 UTC) #2

M-A Ruel

the change seems strange, we were forcing a tuple previously. But I trust you. lgtm

11 years, 1 month ago (2009-11-12 23:29:04 UTC) #3

chase

11 years, 1 month ago (2009-11-12 23:40:26 UTC) #4

On 2009/11/12 23:29:04, Marc-Antoine Ruel wrote:
> the change seems strange, we were forcing a tuple previously.

The Buildbot API says MailNotifier takes a tuple for extraRecipients.  I expect
we were forcing tuple() before to adhere to the documentation.  But since
Buildbot's MailNotifier calls .sort() on that variable later (and crashes
GateKeeper this way), and MailNotifier actually verifies that extraRecipients is
either a tuple or a list, the API documentation ultimately seems to be confused.

See email I sent for more details.  It contains the full story + example stack
trace.

> But I trust you.

Sweet.

> lgtm

Expand Messages | Collapse Messages