Issue 389016: Address post-commit comments from codereview.chromium.org/371059 and codereview.chromium.org/293019

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 389016: Address post-commit comments from codereview.chromium.org/371059 and codereview.chromium.org/293019 (Closed)

Created:
11 years, 1 month ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Address post-commit comments from codereview.chromium.org/371059 and codereview.chromium.org/293019 TEST=BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31801

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -4 lines)			Patch
M	chrome/browser/cocoa/bookmark_bar_view.mm	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/chrome_browser_window.mm	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/cocoa/download_item_controller.mm	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/download_shelf_controller.mm	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_mac.mm	View	1 chunk	+5 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm. thanks!