Issue 3889004: 2nd try:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3889004: 2nd try:... (Closed)

Created:
10 years, 2 months ago by Mike Belshe

Modified:
9 years, 5 months ago

Reviewers:

CC:
chromium-reviews, brettw-cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

2nd try: Fix regression where high resolution timers could be activated even under battery power. Add unit test to protect chromium from developers like me in the future. The fix is a one-liner in hi_res_timer_manager_win.cc. The rest of the code change is the mechanics to enable the unit test. BUG=59528 TEST=HiResTimerManagerTest.ToggleOnOff Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63191

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -12 lines)			Patch
M	app/app.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	app/hi_res_timer_manager.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	app/hi_res_timer_manager_posix.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A	app/hi_res_timer_manager_unittest.cc	View	1 chunk	+51 lines, -0 lines	0 comments	Download
M	app/hi_res_timer_manager_win.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	base/message_loop.cc	View	2 chunks	+14 lines, -3 lines	0 comments	Download
M	base/time.h	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	base/time_win.cc	View	2 chunks	+19 lines, -4 lines	0 comments	Download