Issue 3889002: Covert LOG(INFO) to VLOG(1) - ipc/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3889002: Covert LOG(INFO) to VLOG(1) - ipc/. (Closed)

Created:
10 years, 2 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, jam, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Covert LOG(INFO) to VLOG(1) - ipc/. This also eliminates IPC_MESSAGE_DEBUG_EXTRA and uses VLOG(2) for that. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63142

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -40 lines)			Patch
M	ipc/ipc_channel_posix.cc	View	4 chunks	+8 lines, -14 lines	0 comments	Download
M	ipc/ipc_channel_win.cc	View	4 chunks	+9 lines, -17 lines	0 comments	Download
M	ipc/ipc_logging.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ipc/ipc_sync_channel_unittest.cc	View	2 chunks	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

10 years, 2 months ago (2010-10-19 21:19:19 UTC) #2

lgtm

On Tue, Oct 19, 2010 at 2:16 PM, <pkasting@chromium.org> wrote:

> Reviewers: John Abd-El-Malek,
>
> Description:
> Covert LOG(INFO) to VLOG(1) - ipc/.
>
> This also eliminates IPC_MESSAGE_DEBUG_EXTRA and uses VLOG(2) for that.
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/3889002/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     ipc/ipc_channel_posix.cc
>  M     ipc/ipc_channel_win.cc
>  M     ipc/ipc_logging.cc
>  M     ipc/ipc_sync_channel_unittest.cc
>
>
>

Expand Messages | Collapse Messages