Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 3888001: Two minor changes to the use of FormatMessageA in Win32ErrorLogMessage:... (Closed)

Created:
10 years, 2 months ago by grt (UTC plus 2)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Two minor changes to the use of FormatMessageA in Win32ErrorLogMessage: - Follow the MSDN advice and use FORMAT_MESSAGE_IGNORE_INSERTS to avoid security issues and to prevent getting back ERROR_INVALID_PARAMETER for any message that has inserts. This is always the right thing since this function provides no arguments for inserts. - Don't specify a language identifier, thereby allowing FormatMessageA to make many sensible attempts to find a string in some suitable language. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63166

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/logging.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
grt (UTC plus 2)
Hi Tristan, Would you mind reviewing these small changes to Win32ErrorLogMessage for me? Thanks, Greg
10 years, 2 months ago (2010-10-19 19:33:22 UTC) #1
Tristan Schmelcher 2
10 years, 2 months ago (2010-10-19 19:36:30 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698