Issue 387030: Revert the patch that makes SQLite interpret BEGIN as BEGIN IMMEDIATE,...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 387030: Revert the patch that makes SQLite interpret BEGIN as BEGIN IMMEDIATE,... (Closed)

Created:
11 years, 1 month ago by dumi

Modified:
9 years, 7 months ago

Reviewers:
michaeln, Scott Hess - ex-Googler

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Revert the patch that makes SQLite interpret BEGIN as BEGIN IMMEDIATE, and go back to the default behavior which treats BEGIN as BEGIN DEFERRED. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31763

Patch Set 1 #

Patch Set 2 : Re-uploading the same patch in hope of green-ifiying all trybots. #

Patch Set 3 : Final version. Had to sync README.chromium. #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+205 lines, -229 lines)			Patch
M	third_party/sqlite/README.chromium	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/sqlite/google_generate_preprocessed.sh	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/sqlite/misc.patch	View	1 2	1 chunk	+0 lines, -17 lines	0 comments	Download
M	third_party/sqlite/preprocessed/parse.c	View	1 2	75 chunks	+205 lines, -205 lines	0 comments	Download
M	third_party/sqlite/src/parse.y	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

11 years, 1 month ago (2009-11-11 23:28:09 UTC) #1

lgtm.

Could have also just changed the define in google_generate_preprocessed.sh and
left the code in place.  I don't know if that's a suggestion or not.  Main
upside is that it keeps us consistent with Gears' SQLite.  But if we really
cared about that, we'd have arranged to do it some other way (perhaps with a
shared google code project).

Expand Messages | Collapse Messages