Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Side by Side Diff: chrome_frame/metrics_service.cc

Issue 3869003: Const-ify RefCountedThreadSafe::AddRef and Release. (Closed)
Patch Set: actually remove the cast Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/test/testing_profile.cc ('k') | ipc/ipc_channel_proxy.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 //------------------------------------------------------------------------------ 6 //------------------------------------------------------------------------------
7 // Description of the life cycle of a instance of MetricsService. 7 // Description of the life cycle of a instance of MetricsService.
8 // 8 //
9 // OVERVIEW 9 // OVERVIEW
10 // 10 //
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 public: 203 public:
204 explicit ChromeFrameUploadRequestContextGetter(MessageLoop* io_loop) 204 explicit ChromeFrameUploadRequestContextGetter(MessageLoop* io_loop)
205 : io_loop_(io_loop) {} 205 : io_loop_(io_loop) {}
206 206
207 virtual URLRequestContext* GetURLRequestContext() { 207 virtual URLRequestContext* GetURLRequestContext() {
208 if (!context_) 208 if (!context_)
209 context_ = new ChromeFrameUploadRequestContext(io_loop_); 209 context_ = new ChromeFrameUploadRequestContext(io_loop_);
210 return context_; 210 return context_;
211 } 211 }
212 212
213 virtual scoped_refptr<base::MessageLoopProxy> GetIOMessageLoopProxy() { 213 virtual scoped_refptr<base::MessageLoopProxy> GetIOMessageLoopProxy() const {
214 if (!io_message_loop_proxy_.get()) { 214 if (!io_message_loop_proxy_.get()) {
215 io_message_loop_proxy_ = base::MessageLoopProxy::CreateForCurrentThread(); 215 io_message_loop_proxy_ = base::MessageLoopProxy::CreateForCurrentThread();
216 } 216 }
217 return io_message_loop_proxy_; 217 return io_message_loop_proxy_;
218 } 218 }
219 219
220 private: 220 private:
221 ~ChromeFrameUploadRequestContextGetter() { 221 ~ChromeFrameUploadRequestContextGetter() {
222 DVLOG(1) << __FUNCTION__; 222 DVLOG(1) << __FUNCTION__;
223 } 223 }
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
598 version += "-F"; 598 version += "-F";
599 if (!version_info.IsOfficialBuild()) 599 if (!version_info.IsOfficialBuild())
600 version.append("-devel"); 600 version.append("-devel");
601 return version; 601 return version;
602 } else { 602 } else {
603 NOTREACHED() << "Unable to retrieve version string."; 603 NOTREACHED() << "Unable to retrieve version string.";
604 } 604 }
605 605
606 return std::string(); 606 return std::string();
607 } 607 }
OLDNEW
« no previous file with comments | « chrome/test/testing_profile.cc ('k') | ipc/ipc_channel_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698