Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Unified Diff: webkit/support/webkit_support.cc

Issue 3863002: Refactoring BufferedDataSource to work with WebURLLoader instead of a MediaResourceLoaderBridge. (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: addressing andrew's comments Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/support/webkit_support.cc
diff --git a/webkit/support/webkit_support.cc b/webkit/support/webkit_support.cc
index f6d0b246708eec46c69df8072ce2af8c2d737794..08b46965b3451cd127e4473d00984939647f5f4d 100644
--- a/webkit/support/webkit_support.cc
+++ b/webkit/support/webkit_support.cc
@@ -267,36 +267,17 @@ WebKit::WebMediaPlayer* CreateMediaPlayer(WebFrame* frame,
WebMediaPlayerClient* client) {
scoped_ptr<media::MediaFilterCollection> collection(
new media::MediaFilterCollection());
-
+/*
appcache::WebApplicationCacheHostImpl* appcache_host =
scherkus (not reviewing) 2010/11/30 20:05:39 ditto for this
annacc 2010/11/30 21:51:45 Will do.
appcache::WebApplicationCacheHostImpl::FromFrame(frame);
-
- // TODO(hclam): this is the same piece of code as in RenderView, maybe they
- // should be grouped together.
- webkit_glue::MediaResourceLoaderBridgeFactory* bridge_factory_simple =
- new webkit_glue::MediaResourceLoaderBridgeFactory(
- GURL(), // referrer
- "null", // frame origin
- "null", // main_frame_origin
- base::GetCurrentProcId(),
- appcache_host ? appcache_host->host_id() : appcache::kNoHostId,
- 0);
- webkit_glue::MediaResourceLoaderBridgeFactory* bridge_factory_buffered =
- new webkit_glue::MediaResourceLoaderBridgeFactory(
- GURL(), // referrer
- "null", // frame origin
- "null", // main_frame_origin
- base::GetCurrentProcId(),
- appcache_host ? appcache_host->host_id() : appcache::kNoHostId,
- 0);
-
+*/
scoped_refptr<webkit_glue::VideoRendererImpl> video_renderer(
new webkit_glue::VideoRendererImpl(false));
collection->AddVideoRenderer(video_renderer);
return new webkit_glue::WebMediaPlayerImpl(
- client, collection.release(), bridge_factory_simple,
- bridge_factory_buffered, false, video_renderer);
+ client, collection.release(), frame,
scherkus (not reviewing) 2010/11/30 20:05:39 nit: I think you can fit the params on a single li
annacc 2010/11/30 21:51:45 Done.
+ false, video_renderer);
}
WebKit::WebApplicationCacheHost* CreateApplicationCacheHost(

Powered by Google App Engine
This is Rietveld 408576698