Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: chrome/renderer/render_view.cc

Issue 3863002: Refactoring BufferedDataSource to work with WebURLLoader instead of a MediaResourceLoaderBridge. (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: addressing andrew's comments Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/glue/media/buffered_data_source.h » ('j') | webkit/glue/media/buffered_data_source.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/render_view.cc
diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc
index e3e39dcb394d00b2b41dc6ccb78c50d307e1f43e..4e32cf0f5dc11da41b9c08d27ce21265123060f3 100644
--- a/chrome/renderer/render_view.cc
+++ b/chrome/renderer/render_view.cc
@@ -2662,30 +2662,10 @@ WebMediaPlayer* RenderView::createMediaPlayer(
collection->AddVideoDecoder(new IpcVideoDecoder(
MessageLoop::current(), context->context()));
}
-
+/*
WebApplicationCacheHostImpl* appcache_host =
scherkus (not reviewing) 2010/11/30 20:05:39 has this been addressed yet? I'd ping michaeln ov
annacc 2010/11/30 21:51:45 Will do.
WebApplicationCacheHostImpl::FromFrame(frame);
-
- // TODO(hclam): obtain the following parameters from |client|.
- // Create two bridge factory for two data sources.
- webkit_glue::MediaResourceLoaderBridgeFactory* bridge_factory_simple =
- new webkit_glue::MediaResourceLoaderBridgeFactory(
- GURL(frame->url()), // referrer
- "null", // frame origin
- "null", // main_frame_origin
- base::GetCurrentProcId(),
- appcache_host ? appcache_host->host_id() : appcache::kNoHostId,
- routing_id());
-
- webkit_glue::MediaResourceLoaderBridgeFactory* bridge_factory_buffered =
- new webkit_glue::MediaResourceLoaderBridgeFactory(
- GURL(frame->url()), // referrer
- "null", // frame origin
- "null", // main_frame_origin
- base::GetCurrentProcId(),
- appcache_host ? appcache_host->host_id() : appcache::kNoHostId,
- routing_id());
-
+*/
scoped_refptr<webkit_glue::WebVideoRenderer> video_renderer;
bool pts_logging = cmd_line->HasSwitch(switches::kEnableVideoLogging);
scoped_refptr<webkit_glue::VideoRendererImpl> renderer(
@@ -2694,9 +2674,9 @@ WebMediaPlayer* RenderView::createMediaPlayer(
video_renderer = renderer;
return new webkit_glue::WebMediaPlayerImpl(
- client, collection.release(), bridge_factory_simple,
- bridge_factory_buffered,
- cmd_line->HasSwitch(switches::kSimpleDataSource),video_renderer);
+ client, collection.release(), frame,
+ cmd_line->HasSwitch(switches::kSimpleDataSource),
+ video_renderer);
}
WebApplicationCacheHost* RenderView::createApplicationCacheHost(
« no previous file with comments | « no previous file | webkit/glue/media/buffered_data_source.h » ('j') | webkit/glue/media/buffered_data_source.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698