 Chromium Code Reviews
 Chromium Code Reviews Issue 3863002:
  Refactoring BufferedDataSource to work with WebURLLoader instead of a MediaResourceLoaderBridge.  (Closed) 
  Base URL: http://git.chromium.org/git/chromium.git
    
  
    Issue 3863002:
  Refactoring BufferedDataSource to work with WebURLLoader instead of a MediaResourceLoaderBridge.  (Closed) 
  Base URL: http://git.chromium.org/git/chromium.git| Index: webkit/tools/test_shell/test_webview_delegate.cc | 
| diff --git a/webkit/tools/test_shell/test_webview_delegate.cc b/webkit/tools/test_shell/test_webview_delegate.cc | 
| index 525c501bbaa4a8affb36c2acdd3cda295e54c4b6..9fd9b6adce5ceaad496bb9fd125d7b82d879d6db 100644 | 
| --- a/webkit/tools/test_shell/test_webview_delegate.cc | 
| +++ b/webkit/tools/test_shell/test_webview_delegate.cc | 
| @@ -726,36 +726,17 @@ WebMediaPlayer* TestWebViewDelegate::createMediaPlayer( | 
| WebFrame* frame, WebMediaPlayerClient* client) { | 
| scoped_ptr<media::MediaFilterCollection> collection( | 
| new media::MediaFilterCollection()); | 
| - | 
| +/* | 
| appcache::WebApplicationCacheHostImpl* appcache_host = | 
| appcache::WebApplicationCacheHostImpl::FromFrame(frame); | 
| - | 
| - // TODO(hclam): this is the same piece of code as in RenderView, maybe they | 
| - // should be grouped together. | 
| - webkit_glue::MediaResourceLoaderBridgeFactory* bridge_factory_simple = | 
| - new webkit_glue::MediaResourceLoaderBridgeFactory( | 
| - GURL(frame->url()), // referrer | 
| - "null", // frame origin | 
| - "null", // main_frame_origin | 
| - base::GetCurrentProcId(), | 
| - appcache_host ? appcache_host->host_id() : appcache::kNoHostId, | 
| - 0); | 
| - webkit_glue::MediaResourceLoaderBridgeFactory* bridge_factory_buffered = | 
| - new webkit_glue::MediaResourceLoaderBridgeFactory( | 
| - GURL(frame->url()), // referrer | 
| - "null", // frame origin | 
| - "null", // main_frame_origin | 
| - base::GetCurrentProcId(), | 
| - appcache_host ? appcache_host->host_id() : appcache::kNoHostId, | 
| - 0); | 
| - | 
| +*/ | 
| scoped_refptr<webkit_glue::VideoRendererImpl> video_renderer( | 
| new webkit_glue::VideoRendererImpl(false)); | 
| collection->AddVideoRenderer(video_renderer); | 
| return new webkit_glue::WebMediaPlayerImpl( | 
| - client, collection.release(), bridge_factory_simple, | 
| - bridge_factory_buffered, false, video_renderer); | 
| + client, collection.release(), frame, | 
| 
scherkus (not reviewing)
2010/11/22 21:27:29
all these args can fit on a single line
 
annacc
2010/11/24 21:34:44
Done.
 | 
| + false, video_renderer); | 
| } | 
| WebApplicationCacheHost* TestWebViewDelegate::createApplicationCacheHost( |