Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Unified Diff: webkit/tools/test_shell/test_webview_delegate.cc

Issue 3863002: Refactoring BufferedDataSource to work with WebURLLoader instead of a MediaResourceLoaderBridge. (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: Removed unnecessary WebURLLoaders in the two unittests because windows compilation complains. Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/tools/test_shell/test_webview_delegate.cc
diff --git a/webkit/tools/test_shell/test_webview_delegate.cc b/webkit/tools/test_shell/test_webview_delegate.cc
index 525c501bbaa4a8affb36c2acdd3cda295e54c4b6..9fd9b6adce5ceaad496bb9fd125d7b82d879d6db 100644
--- a/webkit/tools/test_shell/test_webview_delegate.cc
+++ b/webkit/tools/test_shell/test_webview_delegate.cc
@@ -726,36 +726,17 @@ WebMediaPlayer* TestWebViewDelegate::createMediaPlayer(
WebFrame* frame, WebMediaPlayerClient* client) {
scoped_ptr<media::MediaFilterCollection> collection(
new media::MediaFilterCollection());
-
+/*
Alpha Left Google 2010/11/19 22:53:42 add michaeln to look at this code
appcache::WebApplicationCacheHostImpl* appcache_host =
appcache::WebApplicationCacheHostImpl::FromFrame(frame);
-
- // TODO(hclam): this is the same piece of code as in RenderView, maybe they
- // should be grouped together.
- webkit_glue::MediaResourceLoaderBridgeFactory* bridge_factory_simple =
- new webkit_glue::MediaResourceLoaderBridgeFactory(
- GURL(frame->url()), // referrer
- "null", // frame origin
- "null", // main_frame_origin
- base::GetCurrentProcId(),
- appcache_host ? appcache_host->host_id() : appcache::kNoHostId,
- 0);
- webkit_glue::MediaResourceLoaderBridgeFactory* bridge_factory_buffered =
- new webkit_glue::MediaResourceLoaderBridgeFactory(
- GURL(frame->url()), // referrer
- "null", // frame origin
- "null", // main_frame_origin
- base::GetCurrentProcId(),
- appcache_host ? appcache_host->host_id() : appcache::kNoHostId,
- 0);
-
+*/
scoped_refptr<webkit_glue::VideoRendererImpl> video_renderer(
new webkit_glue::VideoRendererImpl(false));
collection->AddVideoRenderer(video_renderer);
return new webkit_glue::WebMediaPlayerImpl(
- client, collection.release(), bridge_factory_simple,
- bridge_factory_buffered, false, video_renderer);
+ client, collection.release(), frame,
+ false, video_renderer);
}
WebApplicationCacheHost* TestWebViewDelegate::createApplicationCacheHost(
« webkit/tools/test_shell/test_shell.gypi ('K') | « webkit/tools/test_shell/test_shell.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698