Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3597)

Unified Diff: chrome/browser/automation/url_request_automation_job.cc

Issue 386008: ChromeFrame HTTP requests would randomly fail if we navigated to multiple HTT... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/automation/url_request_automation_job.h ('k') | chrome/browser/external_tab_container.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/automation/url_request_automation_job.cc
===================================================================
--- chrome/browser/automation/url_request_automation_job.cc (revision 31553)
+++ chrome/browser/automation/url_request_automation_job.cc (working copy)
@@ -52,13 +52,18 @@
URLRequestAutomationJob::URLRequestAutomationJob(URLRequest* request, int tab,
int request_id, AutomationResourceMessageFilter* filter)
: URLRequestJob(request),
- id_(request_id),
tab_(tab),
message_filter_(filter),
pending_buf_size_(0),
- redirect_status_(0) {
+ redirect_status_(0),
+ request_id_(request_id) {
DLOG(INFO) << "URLRequestAutomationJob create. Count: " << ++instance_count_;
- DCHECK_NE(id_, -1);
+ DCHECK(message_filter_ != NULL);
+
+ if (message_filter_) {
+ id_ = message_filter_->NewAutomationRequestId();
+ DCHECK_NE(id_, 0);
+ }
}
URLRequestAutomationJob::~URLRequestAutomationJob() {
@@ -217,7 +222,8 @@
case AutomationMsg_RequestEnd::ID: {
void* iter = NULL;
int tab = 0;
- if (message.ReadInt(&iter, &tab) && message.ReadInt(&iter, request_id)) {
+ if (message.ReadInt(&iter, &tab) &&
+ message.ReadInt(&iter, request_id)) {
return true;
}
break;
« no previous file with comments | « chrome/browser/automation/url_request_automation_job.h ('k') | chrome/browser/external_tab_container.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698