Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1517)

Issue 386001: Reapply 3246 and 3247 after fixing valgrind warning. (Closed)

Created:
11 years, 1 month ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Reapply 3246 and 3247 after fixing valgrind warning.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -27 lines) Patch
M src/scanner.h View 5 chunks +31 lines, -12 lines 0 comments Download
M src/scanner.cc View 5 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
Valgrind did have a point that a variable was read before being assigned (perfectly safe ...
11 years, 1 month ago (2009-11-10 09:28:42 UTC) #1
Erik Corry
11 years, 1 month ago (2009-11-10 09:56:47 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698