Update prebuilt to modify make.conf files for the board/host targets.

Update prebuilt to modify make.conf files for the board/host targets.
This changes the format that I was updating from 'key value' to 'key=value'.
I modified my unittests to test this.

BUG=NA
TEST=Branch runs without commit.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=fe3805a

[anush, 2010-10-18 22:33:25]

LGTM w/nits

http://codereview.chromium.org/3858003/diff/1/2
File prebuilt.py (right):

http://codereview.chromium.org/3858003/diff/1/2#newcode121
prebuilt.py:121: cros_build_lib.RunCommand('git pull', shell=True)
You could do a "repo sync ." here to achieve the same result (it rebases
better). Do you want to move this just above the git commit to reduce the commit
window ?

http://codereview.chromium.org/3858003/diff/1/2#newcode132
prebuilt.py:132: cros_build_lib.RunCommand('git pull', shell=True)
"repo sync ." does the same and handles rebases etc since it reapplies your
local changes.

[sosa, 2010-10-18 22:34:44]

LGTM here too with nits

http://codereview.chromium.org/3858003/diff/1/2
File prebuilt.py (right):

http://codereview.chromium.org/3858003/diff/1/2#newcode53
prebuilt.py:53: 'make.conf.amd64-host')}
line up with _PRE...

http://codereview.chromium.org/3858003/diff/1/2#newcode66
prebuilt.py:66: """Raised when a function finds an unknown board format."""
You don't need a pass here?

http://codereview.chromium.org/3858003/diff/1/2#newcode78
prebuilt.py:78: key: The variable key to update. (Default: PORTAGE_BINHOST)
Move above value

http://codereview.chromium.org/3858003/diff/1/2#newcode93
prebuilt.py:93: file_lines.append('%s="%s"' % (key, value))
optional nit:

have a format string "%(key)s=%(value)s" you re-use ... also helps to change
format later.

[scottz, 2010-10-18 22:54:55]

PTAL

http://codereview.chromium.org/3858003/diff/1/2
File prebuilt.py (right):

http://codereview.chromium.org/3858003/diff/1/2#newcode53
prebuilt.py:53: 'make.conf.amd64-host')}
On 2010/10/18 22:34:45, sosa wrote:
> line up with _PRE...

Done.

http://codereview.chromium.org/3858003/diff/1/2#newcode66
prebuilt.py:66: """Raised when a function finds an unknown board format."""
On 2010/10/18 22:34:45, sosa wrote:
> You don't need a pass here?

Done.

http://codereview.chromium.org/3858003/diff/1/2#newcode78
prebuilt.py:78: key: The variable key to update. (Default: PORTAGE_BINHOST)
Why?
On 2010/10/18 22:34:45, sosa wrote:
> Move above value

http://codereview.chromium.org/3858003/diff/1/2#newcode93
prebuilt.py:93: file_lines.append('%s="%s"' % (key, value))
On 2010/10/18 22:34:45, sosa wrote:
> optional nit:
> 
> have a format string "%(key)s=%(value)s" you re-use ... also helps to change
> format later.
> 

Done.

http://codereview.chromium.org/3858003/diff/1/2#newcode121
prebuilt.py:121: cros_build_lib.RunCommand('git pull', shell=True)
On 2010/10/18 22:33:25, anush wrote:
> You could do a "repo sync ." here to achieve the same result (it rebases
> better). Do you want to move this just above the git commit to reduce the
commit
> window ?

Done.

http://codereview.chromium.org/3858003/diff/1/2#newcode132
prebuilt.py:132: cros_build_lib.RunCommand('git pull', shell=True)
On 2010/10/18 22:33:25, anush wrote:
> "repo sync ." does the same and handles rebases etc since it reapplies your
> local changes. 

Done.

[sosa, 2010-10-18 22:57:43]

LGTM

http://codereview.chromium.org/3858003/diff/1/2
File prebuilt.py (right):

http://codereview.chromium.org/3858003/diff/1/2#newcode78
prebuilt.py:78: key: The variable key to update. (Default: PORTAGE_BINHOST)
You had it before ... generally read Key before Value, but it's not a big deal
if you don't.

On 2010/10/18 22:54:55, scottz wrote:
> Why?
> On 2010/10/18 22:34:45, sosa wrote:
> > Move above value
> 
>