Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: net/net.gyp

Issue 3855004: Make USE_OPENSSL and USE_NSS mutually exclusive (Closed)
Patch Set: wtc comments Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/des.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/net.gyp
diff --git a/net/net.gyp b/net/net.gyp
index e8a32c9c602ce27aae06cffe8bfa72e169bb12a6..0f1677191f40f3f422560616d2d69beb076ea4fb 100644
--- a/net/net.gyp
+++ b/net/net.gyp
@@ -234,9 +234,19 @@
'dependencies': [
'../build/linux/system.gyp:gconf',
'../build/linux/system.gyp:gdk',
- '../build/linux/system.gyp:nss',
'../build/linux/system.gyp:libresolv',
],
+ 'conditions': [
+ ['use_openssl==1', {
+ 'dependencies': [
+ '../build/linux/system.gyp:openssl',
+ ],
+ }, { # else: not using openssl. Use NSS.
+ 'dependencies': [
+ '../build/linux/system.gyp:nss',
+ ],
+ }],
+ ],
},
{ # else: OS is not in the above list
'sources!': [
@@ -254,12 +264,14 @@
],
},
],
- [ 'use_openssl == 1 and OS == "linux"', {
- # When building for OpenSSL, we need to exclude some NSS files.
- # TODO(bulach): remove once we fully support OpenSSL.
+ [ 'use_openssl==1', {
'sources!': [
'base/cert_database_nss.cc',
+ 'base/dnssec_keyset.cc',
+ 'base/dnssec_keyset.h',
'base/keygen_handler_nss.cc',
+ 'base/nss_memio.c',
+ 'base/nss_memio.h',
'base/x509_certificate_nss.cc',
'third_party/mozilla_security_manager/nsKeygenHandler.cpp',
'third_party/mozilla_security_manager/nsKeygenHandler.h',
@@ -271,7 +283,7 @@
'third_party/mozilla_security_manager/nsPKCS12Blob.h',
],
},
- { # else: not using openssl.
+ { # else: not using openssl.
'sources!': [
'base/cert_database_openssl.cc',
'base/keygen_handler_openssl.cc',
@@ -702,7 +714,7 @@
'proxy/proxy_config_service_linux.h',
],
}],
- ['use_openssl==1 and OS == "linux"', {
+ ['use_openssl==1', {
'dependencies': [
'../build/linux/system.gyp:openssl',
],
@@ -973,11 +985,13 @@
}],
],
}],
- [ 'use_openssl == 1 and OS == "linux"', {
- # When building for OpenSSL, we need to exclude some NSS files.
- # TODO(bulach): remove once we fully support OpenSSL.
+ [ 'use_openssl==1', {
+ # When building for OpenSSL, we need to exclude NSS specific tests.
+ # TODO(bulach): Add equivalent tests when the underlying
+ # functionality is ported to OpenSSL.
'sources!': [
'base/cert_database_nss_unittest.cc',
+ 'base/dnssec_unittest.cc',
],
},
],
@@ -1107,8 +1121,16 @@
],
}],
['OS == "linux" or OS == "freebsd" or OS == "openbsd"', {
- 'dependencies': [
- '../build/linux/system.gyp:nss',
+ 'conditions': [
+ ['use_openssl==1', {
+ 'dependencies': [
+ '../build/linux/system.gyp:openssl',
+ ]
+ }, {
+ 'dependencies': [
+ '../build/linux/system.gyp:nss',
+ ],
+ }],
],
}],
['OS == "linux"', {
@@ -1120,11 +1142,6 @@
}],
],
}],
- ['use_openssl == 1 and OS == "linux"', {
- 'dependencies': [
- '../build/linux/system.gyp:openssl',
- ]
- }],
],
},
{
« no previous file with comments | « net/http/des.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698