Issue 3851003: Fix double-rounding in strtod.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3851003: Fix double-rounding in strtod. (Closed)

Created:
10 years, 2 months ago by Florian Loitsch

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Visibility:
Public.

Description

Fix double-rounding in strtod. Don't use floating-point operations on Linux,x86 to compute strtod. Since the floating-point stack on Linux is set to 80bit double rounding may occure. When falling back to gay_strtod append several '0's so that Gay doesn't take the same shortcut either. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=5650

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -14 lines)			Patch
	M	src/strtod.cc	View		4 chunks	+45 lines, -14 lines	0 comments	Download
	M	test/cctest/test-strtod.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages