Issue 385092: Add a regression test that exposes a stack corruption problem....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 385092: Add a regression test that exposes a stack corruption problem.... (Closed)

Created:
11 years, 1 month ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add a regression test that exposes a stack corruption problem. See http://code.google.com/p/chromium/issues/detail?id=27227 Committed: http://code.google.com/p/v8/source/detail?r=3303

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -0 lines)			Patch
	A	test/mjsunit/regress/regress-2249423.js	View	1	1 chunk	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM, thanks! http://codereview.chromium.org/385092/diff/1/2 File test/mjsunit/regress/regress-2249423.js (right): http://codereview.chromium.org/385092/diff/1/2#newcode1 Line 1: // Copyright 2008 the V8 project ...

11 years, 1 month ago (2009-11-13 13:47:03 UTC) #2

fschneider

11 years, 1 month ago (2009-11-13 13:57:45 UTC) #3

http://codereview.chromium.org/385092/diff/1/2
File test/mjsunit/regress/regress-2249423.js (right):

http://codereview.chromium.org/385092/diff/1/2#newcode1
Line 1: // Copyright 2008 the V8 project authors. All rights reserved.
On 2009/11/13 13:47:05, Mads Ager wrote:
> 2008 -> 2009

Done.

http://codereview.chromium.org/385092/diff/1/2#newcode29
Line 29: // Exposes stack corruption issue
On 2009/11/13 13:47:05, Mads Ager wrote:
> Add period at end of comment.  Maybe say: Regression test for stack corruption
> issue? 

Done.

Expand Messages | Collapse Messages

Issue 385092: Add a regression test that exposes a stack corruption problem.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages