Issue 385084: Partially revert WebKit.gyp switch-over, because it broke build bot setup...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 385084: Partially revert WebKit.gyp switch-over, because it broke build bot setup... (Closed)

Created:
11 years, 1 month ago by dglazkov

Modified:
9 years, 6 months ago

Reviewers:
levin, yaar

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Partially revert WebKit.gyp switch-over, because it broke build bot setup in subtle and devious ways. Renaming webkit.gyp -> webkit_glue.gyp changed webkit.sln to webkit_glue.sln, which occured unbeknownst to the builders who continued to build webkit.sln for most of the day. This wasn't an issue until we did a WebKit roll, where the trickery was discovered and hell broke loose. TBR=yaar TEST=green bots BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31887

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -574 lines)			Patch
M	build/all.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/locales/locales.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome.gyp	View	10 chunks	+12 lines, -12 lines	0 comments	Download
M	chrome/test/interactive_ui/interactive_ui_tests.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/default_plugin/default_plugin.gyp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.gyp	View	3 chunks	+7 lines, -7 lines	0 comments	Download
D	webkit/webkit_glue.gyp	View	1 chunk	+0 lines, -551 lines	0 comments	Download
A +	webkit\webkit.gyp	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

yaar

The rename was purposeful. Having two projects have the same name is confusing, especially if ...

11 years, 1 month ago (2009-11-13 05:21:22 UTC) #3

dglazkov

11 years, 1 month ago (2009-11-13 05:29:19 UTC) #5

The clobber would've broken it. Like it did on the canary:

http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20(webkit.or...

Expand Messages | Collapse Messages