Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 385070: Top-level compiler: Re-allow non-lazily compiled function literals.... (Closed)

Created:
11 years, 1 month ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Top-level compiler: Re-allow non-lazily compiled function literals. This change re-allows non-lazy compiled function literals for top-level compilation. There was a problem on ARM exposed through this change which was fixed as part of r3289 in fast-codegen-arm.cc (Threading and Threading2 tests failed) It occurred before r3289 when we allocate a local context at the beginning of a function. The code for the stack check was split up in an unintended way (load of stack check limit into r2, and use of r2 in the actual stack check code). Committed: http://code.google.com/p/v8/source/detail?r=3300

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
I think we can enable non-lazy function literals in the top-level compiler now. Or is ...
11 years, 1 month ago (2009-11-12 17:00:43 UTC) #1
William Hesse
11 years, 1 month ago (2009-11-13 09:45:18 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698