Issue 385058: When extensions use notifications, display the name of the extension in UI ra...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 385058: When extensions use notifications, display the name of the extension in UI ra... (Closed)

Created:
11 years, 1 month ago by John Gregg

Modified:
9 years ago

Reviewers:
michaeln

CC:
Aaron Boodman, chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

When extensions use notifications, display the name of the extension in UI rather than the "origin". BUG=26961 TEST=test extension linked in the bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31799

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -8 lines)			Patch
M	chrome/browser/notifications/desktop_notification_service.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/desktop_notification_service.cc	View	1	9 chunks	+31 lines, -6 lines	0 comments	Download
M	chrome/browser/notifications/desktop_notifications_unittest.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/notification.h	View		4 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/views/notifications/balloon_view.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

michaeln

LGTM http://codereview.chromium.org/385058/diff/1/3 File chrome/browser/notifications/desktop_notification_service.cc (right): http://codereview.chromium.org/385058/diff/1/3#newcode335 Line 335: return display_name; maybe nuke the local var ...

11 years, 1 month ago (2009-11-12 03:41:56 UTC) #2

lgtm (modulo the compile errors)

Expand Messages | Collapse Messages