Issue 385035: Restore info needed to register profile ticks in functions from...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 385035: Restore info needed to register profile ticks in functions from... (Closed)

Created:
11 years, 1 month ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Mikhail Naganov

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Restore info needed to register profile ticks in functions from the snapshot. Still needed: info to register profile ticks in stubs. Committed: http://code.google.com/p/v8/source/detail?r=3272

Patch Set 1 #

Created: 11 years, 1 month ago

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -19 lines)
M	src/accessors.cc	View	1 chunk	+8 lines, -1 line	0 comments
M	src/factory.cc	View	1 chunk	+2 lines, -1 line	0 comments
M	src/handles.cc	View	3 chunks	+11 lines, -11 lines	0 comments
M	src/objects.h	View	2 chunks	+10 lines, -4 lines	0 comments
M	src/objects-debug.cc	View	1 chunk	+2 lines, -1 line	0 comments
M	src/objects-inl.h	View	1 chunk	+2 lines, -1 line	0 comments
M	src/v8.cc	View	2 chunks	+6 lines, -0 lines	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mikhail Naganov

11 years, 1 month ago (2009-11-11 08:57:14 UTC) #2

LGTM

Please add a comment somewhere why we need to hold both types of line ends
array. Otherwise somebody may be tempted to try to get rid of one of them.

Expand Messages | Collapse Messages