Issue 385001: Report both size and count from the heap profile processor...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 385001: Report both size and count from the heap profile processor... (Closed)

Created:
11 years, 1 month ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Report both size and count from the heap profile processor Added two options for controlling this --size and --count. Default is --size to match the original behaviour. Committed: http://code.google.com/p/v8/source/detail?r=3256

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -7 lines)			Patch
	M	tools/process-heap-prof.py	View	1	2 chunks	+47 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

Lgtm. http://codereview.chromium.org/385001/diff/1/2 File tools/process-heap-prof.py (right): http://codereview.chromium.org/385001/diff/1/2#newcode77 Line 77: if (options.count): Don't need parens. http://codereview.chromium.org/385001/diff/1/2#newcode105 Line ...

11 years, 1 month ago (2009-11-10 08:57:11 UTC) #2

Søren Thygesen Gjesse

11 years, 1 month ago (2009-11-10 10:29:56 UTC) #3

http://codereview.chromium.org/385001/diff/1/2
File tools/process-heap-prof.py (right):

http://codereview.chromium.org/385001/diff/1/2#newcode77
Line 77: if (options.count):
On 2009/11/10 08:57:11, Christian Plesner Hansen wrote:
> Don't need parens.

Done.

http://codereview.chromium.org/385001/diff/1/2#newcode105
Line 105: parser = BuildOptions()
On 2009/11/10 08:57:11, Christian Plesner Hansen wrote:
> Per google style this should be packed into a function that is only called if
> __name__ == '__main__'.

Done.

Expand Messages | Collapse Messages