Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3850002: Convert LOG(INFO) to VLOG(1) - chrome_frame/. (Closed)

Created:
10 years, 2 months ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
amit, sanjeevr
CC:
chromium-reviews, amit, darin-cc_chromium.org, cbentzel+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Convert LOG(INFO) to VLOG(1) - chrome_frame/. Plus a couple misc. cleanups. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -359 lines) Patch
M chrome_frame/bho.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome_frame/bind_status_callback_impl.cc View 12 chunks +26 lines, -25 lines 0 comments Download
M chrome_frame/buggy_bho_handling.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_active_document.cc View 13 chunks +29 lines, -28 lines 0 comments Download
M chrome_frame/chrome_frame_activex.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome_frame/chrome_frame_activex_base.h View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome_frame/chrome_frame_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/chrome_frame_npapi.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome_frame/chrome_frame_npapi_entrypoints.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/chrome_frame_plugin.h View 5 chunks +6 lines, -7 lines 0 comments Download
M chrome_frame/chrome_protocol.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome_frame/crash_reporting/minidump_test.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome_frame/delete_chrome_history.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome_frame/http_negotiate.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome_frame/metrics_service.cc View 7 chunks +10 lines, -12 lines 0 comments Download
M chrome_frame/np_event_listener.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome_frame/npapi_url_request.cc View 4 chunks +15 lines, -15 lines 0 comments Download
M chrome_frame/ole_document_impl.h View 11 chunks +30 lines, -40 lines 0 comments Download
M chrome_frame/policy_settings.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome_frame/protocol_sink_wrap.cc View 14 chunks +24 lines, -24 lines 0 comments Download
M chrome_frame/task_marshaller.cc View 3 chunks +9 lines, -4 lines 0 comments Download
chrome_frame/test/chrome_frame_test_utils.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome_frame/test/chrome_frame_ui_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome_frame/test/http_negotiate_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/test/ie_event_sink.h View 1 chunk +8 lines, -4 lines 0 comments Download
M chrome_frame/test/ie_event_sink.cc View 10 chunks +12 lines, -12 lines 0 comments Download
M chrome_frame/test/mock_ie_event_sink_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/net/test_automation_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/test/perf/chrome_frame_perftest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome_frame/test/test_server.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/test_with_web_server.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome_frame/urlmon_bind_status_callback.cc View 5 chunks +11 lines, -12 lines 0 comments Download
M chrome_frame/urlmon_moniker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/urlmon_moniker.cc View 6 chunks +13 lines, -13 lines 0 comments Download
M chrome_frame/urlmon_url_request.cc View 31 chunks +58 lines, -56 lines 0 comments Download
M chrome_frame/utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
chrome_frame/utils.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Kasting
10 years, 2 months ago (2010-10-16 01:40:46 UTC) #1
sanjeevr
LGTM as far as I can tell. Added Amit as a reviewer because his team ...
10 years, 2 months ago (2010-10-18 22:24:59 UTC) #2
Peter Kasting
Amit, any objections?
10 years, 2 months ago (2010-10-19 17:35:52 UTC) #3
amit
10 years, 2 months ago (2010-10-19 17:59:54 UTC) #4 
LGTM

On Tue, Oct 19, 2010 at 10:35 AM, <pkasting@chromium.org> wrote:

> Amit, any objections?
>
>
> http://codereview.chromium.org/3850002/show
>

Powered by Google App Engine
This is Rietveld 408576698