Issue 3847005: Leave bGlobalLock unlocked in normal recovery mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3847005: Leave bGlobalLock unlocked in normal recovery mode. (Closed)

Created:
10 years, 2 months ago by Randall Spangler

Modified:
9 years, 7 months ago

Reviewers:
Luigi Semenzato

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Bill Richardson, Luigi Semenzato

Base URL:
http://git.chromium.org/git/vboot_reference.git

Visibility:
Public.

Description

This enables a normal recovery mode image to fix problems with the TPM. Change-Id: I8260d9596640e79af24c02ca1da5b47eb2caeaa7 BUG=chrome-os-partner:1439 TEST=manual Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3e2c742

Patch Set 1 #

Total comments: 1

Patch Set 2 : Just call SetupTPM() #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -11 lines)			Patch
	M	firmware/lib/rollback_index.c	View	1	1 chunk	+6 lines, -10 lines	0 comments	Download
	M	firmware/version.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

Just a nit, and I need to check the call site, which I will do ...

10 years, 2 months ago (2010-10-18 23:31:29 UTC) #2

Luigi Semenzato

10 years, 2 months ago (2010-10-18 23:39:00 UTC) #3

LGTM  (I checked the call site)

On 2010/10/18 23:31:29, Luigi Semenzato wrote:
> Just a nit, and I need to check the call site, which I will do from the bus in
a
> few minutes.
> 
> http://codereview.chromium.org/3847005/diff/1/2
> File firmware/lib/rollback_index.c (right):
> 
> http://codereview.chromium.org/3847005/diff/1/2#newcode391
> firmware/lib/rollback_index.c:391: return TPM_SUCCESS;
> There is an extra "*" in the comment.
> 
> Why not get rid of "return TPM_SUCCESS" and simply have
> 
> return SetupTPM(...)
> 
> Either way the comment should probably go first.

Expand Messages | Collapse Messages