Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3845006: Try to simplify the semantics of the profiling code by making... (Closed)

Created:
10 years, 2 months ago by Kasper Lund
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Try to simplify the semantics of the profiling code by making sure to suspend the thread (if necessary) on mac/win32 before reading the VM state. Avoid dealing with signals delivered to non-VM threads on linux no matter if we're profiling or not. Committed: http://code.google.com/p/v8/source/detail?r=5641

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -27 lines) Patch
M src/log.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/platform.h View 1 chunk +10 lines, -3 lines 0 comments Download
M src/platform-linux.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M src/platform-macos.cc View 5 chunks +22 lines, -9 lines 0 comments Download
M src/platform-win32.cc View 4 chunks +22 lines, -8 lines 0 comments Download
M test/cctest/test-log.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
10 years, 2 months ago (2010-10-18 11:29:48 UTC) #1
Mads Ager (chromium)
10 years, 2 months ago (2010-10-18 11:42:04 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698